Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752607AbdI1DK4 (ORCPT ); Wed, 27 Sep 2017 23:10:56 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:52680 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166AbdI1DKz (ORCPT ); Wed, 27 Sep 2017 23:10:55 -0400 Subject: Re: [PATCH] mmc:host:sdhci-pci: Addition of Arasan PCI controller with integrated phy. To: Atul Garg , Shawn Lin CC: , , , , , , References: <1506452394-23655-1-git-send-email-agarg@arasan.com> <424b095f-08ec-96a5-b0b2-3fdc6f7a06ad@rock-chips.com> From: Nishanth Menon Message-ID: <95186e1f-98dc-1a9b-15a9-03911fd2012f@ti.com> Date: Wed, 27 Sep 2017 22:10:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 35 On 09/27/2017 02:27 PM, Atul Garg wrote: > On Sep 26, 2017 8:55 PM, "Shawn Lin" > wrote: > On 2017/9/27 2:59, Atul Garg wrote: [...] > --- >   drivers/mmc/host/sdhci-pci-core.c | 372 > ++++++++++++++++++++++++++++++++++++++ > > > Fundamentally maybe you need a sdhci-pci-arasan.c > > And the arasan PHY isn't new here as sdhci-of-arasan already added > arasan PHY support for eMMC 5.1, but just with different register > layout and content. So could you also use generic PHY framework? > > > Thanks. We are doing two things adding support for Arasan PCI SDHC and > PHY specific code to it integrated via a window in same PCI address > space (extended). > > If we correctly understand, you are suggesting to take the PHY code > out as a PHY driver module similar to phy/rockchip/ and use those > functions from phy framework within the sdhci-pci-core? yes, it might allow some reuse possibly as well. -- Regards, Nishanth Menon PS: please switch to plain text.