Date: Thu, 28 Sep 2017 13:17:50 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Alexander Kochetkov <al.kochet@gmail.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: pl330: fix descriptor allocation fail
Message-ID: <20170928074750.GZ30097@localhost>
References: <1504864826-14202-1-git-send-email-al.kochet@gmail.com>
 <20170926173741.GT30097@localhost>
 <CD7EEDA0-AF93-47AB-8929-141BB335F3C8@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CD7EEDA0-AF93-47AB-8929-141BB335F3C8@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1144
Lines: 35

On Tue, Sep 26, 2017 at 09:03:50PM +0300, Alexander Kochetkov wrote:
> Hello Vinod! Thanks for review!
> 
> > 26 сент. 2017 г., в 20:37, Vinod Koul <vinod.koul@intel.com> написал(а):
> > 
> > Tested-by please...
> 
> In order to test the patch the driver should be rebuild with NR_DEFAULT_DESC defined to 1
> and with some trace code included. Is it OK if I provide second patch I used for testing
> with trace showing how change work?
> 
> > one more wrapper why, we dont have any logic here!
> The idea was to keep rest of driver code intact. Ok, I’ll send v2 with no wrappers.
> 
> > right justifed please
> 
> 
> Some functions has two tabs on second line, some has alignment to beginning of
> argument declaration. How correct?
> 
> 1) or like this (two tabs)
> static int add_desc(struct list_head *pool, spinlock_t *lock,
>                 gfp_t flg, int count)
> 
> 2) Like this:
> static int add_desc(struct list_head *pool, spinlock_t *lock,
> 		               gfp_t flg, int count)

Second one with one more tab :)

See Section 2  Breaking long lines and strings in
Documentation/process/coding-style.rst

-- 
~Vinod