Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752591AbdI1JgZ (ORCPT ); Thu, 28 Sep 2017 05:36:25 -0400 Received: from mga02.intel.com ([134.134.136.20]:17678 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750891AbdI1JgX (ORCPT ); Thu, 28 Sep 2017 05:36:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,449,1500966000"; d="asc'?scan'208";a="1176611947" From: Felipe Balbi To: Kees Cook , Thomas Gleixner Cc: Kees Cook , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 16/31] usb/phy-isp1301-omap: Remove .data assignment In-Reply-To: <1505950075-50223-17-git-send-email-keescook@chromium.org> References: <1505950075-50223-1-git-send-email-keescook@chromium.org> <1505950075-50223-17-git-send-email-keescook@chromium.org> Date: Thu, 28 Sep 2017 12:36:15 +0300 Message-ID: <874lrnkvw0.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1692 Lines: 49 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Kees Cook writes: > The .data assignment appears to be redundant to the WORK_STOP bit for > stopping the timer. Also, it appears this timer is entirely unused > as it is only ever started under #define VERBOSE, which is explicitly > undefined. > > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Kees Cook Are you merging these as part of a larger series altogether, or should I pick the patches that concern me? If you're taking them all together: Acked-by: Felipe Balbi =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlnMwo8ACgkQzL64meEa mQaDwxAAznM8HRHE/FZ1nkD3Q0ulJT45YK5mOAbl9eIuFjs6BjHiMGPpPFFithEd iLJhvKlHG1nppH+g7kVTtH2tlSoTNxIINEoNST+IGJMCC3XrDhqbZjmN51KNglFu GWX2PCXxsIG0traYc0Yp0y2GZNd4IISTyQzIOTI0W6okNEtJxFxAWpoGAJkAU9+x 2Gp6c1KYOM8ONyFxyZqcKBtpMQeAXHx/CLIucapdkjYRaa7YkYKIJpdlDFugvfQ4 oEtwAHAGVNRcY4Ifq72MA1VvaTnYMGxFDN+5V42w0aa52PpvR8IpU3RDIN62GqpK edbmemty9INw/NdXeoUNIgw8dyZODnYnx9rCjaMh4CbsFPauec7NAO4NeY6PTqF9 P8LZJtpWUIFyaf4R2/rMgDVV2oJZPhWfpg/EBYoyRK6XapxSAZ+1sYLzuQIteSWn xExUSWCp6L5vVGGjPIWutok2llwayw5U5X1wIoenyW1eRu4hpxiEOTvABsvFKxY/ E3RemE5OWCFjXbo6GO2Gu2Xmwl5R9qRYZ1VnoqmiR9MlSAwcssu43NDunEiQsojJ YXFv00QguGj65HH64I/YHntwbzJgOrWX+GBjfzusCtGy8YOMpoipgCxNGzBqXPxH q/NwBEmraQM2thqzEBZtsdya9eVULT1aoJ8z1a5iSt9hP0oeZhA= =ubfo -----END PGP SIGNATURE----- --=-=-=--