Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752650AbdI1Jgr (ORCPT ); Thu, 28 Sep 2017 05:36:47 -0400 Received: from mga09.intel.com ([134.134.136.24]:52522 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbdI1Jgp (ORCPT ); Thu, 28 Sep 2017 05:36:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,449,1500966000"; d="asc'?scan'208";a="1224716500" From: Felipe Balbi To: Kees Cook , Thomas Gleixner Cc: Kees Cook , Greg Kroah-Hartman , Raviteja Garimella , Michal Nazarewicz , "Gustavo A. R. Silva" , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 27/31] usb/gadget/snps_udc_core: Remove struct timer_list.data use In-Reply-To: <1505950075-50223-28-git-send-email-keescook@chromium.org> References: <1505950075-50223-1-git-send-email-keescook@chromium.org> <1505950075-50223-28-git-send-email-keescook@chromium.org> Date: Thu, 28 Sep 2017 12:36:37 +0300 Message-ID: <871smrkvve.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1693 Lines: 44 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Kees Cook writes: > If the probe fails, udc_remove() will not be called, so there is no > reason to make del_timer_sync() calls conditional. As a result, use of > the .data field can be dropped, in support of making removing this field > entirely from struct timer_list. > > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: Raviteja Garimella > Cc: Michal Nazarewicz > Cc: "Gustavo A. R. Silva" > Cc: linux-usb@vger.kernel.org > Signed-off-by: Kees Cook Acked-by: Felipe Balbi =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlnMwqUACgkQzL64meEa mQbAFQ//QMCP0BGT1URay8Si7kFvUO2LewCH+peyX5jhrt8NFFrM1sr4hmcr5vns f2pa3mBqThl6jOUiOQkSnu1Rgt4D0ljohWTpPZpI+sAMYtu+comDuD1VGvdhLPTH QVtmvU7Gq6Zng5xD+n+SrEYoaQyAtt+khiJ1RrVlz2JXmYgkpDmxYPXpwkUqbf+b i54qTfvTo6GyAOIC0SfglB4FrydMZj0umEyBreft/Q1/4domWsQK3klJl13vbK7W StRGWQfr1wUbt7oURL+ypFMCySfMaK/f8IR9wcRBYK3sxp6rcdO/PEZzaLXh3H95 uFUOSaYhxZvgcIhn/eejepq0nzlgdkoMXRasCH2c5vZrjDFlMz55aonpsZhohPk+ 5SsgGrd5nPw/O0wdBKojhR5iIo6lrzk53+AcvdmCMJ9YG32pri11bh8ZrBDEWYPY YuZ+w8fIFPpPpkF0Ad3LPt1AdXWcindpimJyOzelcGyn8VkizSklcvosjbxkVFOc k4bQ7k96UG54pC9+5FI3+XciuVBdMNY4UAwZMI/3KbGb+H0UI9a5H/5AKRl7gpvi NQBkQ7ul/BUQVdYpFWvjQgq3qzfzZE5Ge0fvjh1xHo2ZoWDszIjb2mNCJDJbN/bO mk64htOlcbU25l7H5WlqU0D5th5B19lawp6G+Fqlg4MVOP1V6v0= =ySlR -----END PGP SIGNATURE----- --=-=-=--