Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752577AbdI1JjC (ORCPT <rfc822;w@1wt.eu>);
        Thu, 28 Sep 2017 05:39:02 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:60198 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751580AbdI1JjA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 28 Sep 2017 05:39:00 -0400
Date: Thu, 28 Sep 2017 11:38:47 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
        "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>,
        alexander.levin@verizon.com, pmladek@suse.com,
        sergey.senozhatsky@gmail.com, rostedt@goodmis.org
Subject: Re: sched: serial port lockdep warning when offlining CPUs
Message-ID: <20170928093847.zgcgvxb7ajiaywbr@hirez.programming.kicks-ass.net>
References: <CA+1xoqf6kLXzaBgwmaaqffju1WHPSQtDaxiub1Ag_MsTWcKb6g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+1xoqf6kLXzaBgwmaaqffju1WHPSQtDaxiub1Ag_MsTWcKb6g@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1397
Lines: 32

On Thu, Sep 28, 2017 at 02:19:46AM -0700, Sasha Levin wrote:
> Hi all,
> 
> I seem to be hitting the following warning when offlining CPUs on the
> latest -next kernel:
> 
> [289683102.607076] Unregister pv shared memory for cpu 8
> [289683102.622922] select_fallback_rq: 3 callbacks suppressed

This is because you hit a printk() from the scheduler, that's known
broken (along with the rest of printk).

You forgot to actually include that printk() though I suspect it reads
like:

  "process %d (%s) no longer affine to cpu%d\n"

Now that uses printk_deferred() which _should_ work lots better, but
clearly the printk() stuff went wobbly again.

> [289683102.626292] vprintk_emit (kernel/printk/printk.c:1876)
> [289683102.626294] vprintk_default (kernel/printk/printk.c:1918)
> [289683102.626295] vprintk_func (kernel/printk/printk_safe.c:382)
> [289683102.626297] printk (kernel/printk/printk.c:1943)
> [289683102.626299] ? show_regs_print_info (kernel/printk/printk.c:1943)
> [289683102.626301] ? lock_acquire (kernel/locking/lockdep.c:4004)
> [289683102.626306] ___ratelimit (lib/ratelimit.c:52)
> [289683102.626309] __printk_ratelimit (kernel/printk/printk.c:2874)
> [289683102.626311] select_fallback_rq (kernel/sched/core.c:1525 (discriminator 1))
> [289683102.626313] sched_cpu_dying (kernel/sched/core.c:5500 kernel/sched/core.c:5687)

Also, could you pretty please not line wrap logs?