Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbdI1Jq0 (ORCPT ); Thu, 28 Sep 2017 05:46:26 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:38520 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbdI1JqZ (ORCPT ); Thu, 28 Sep 2017 05:46:25 -0400 Date: Thu, 28 Sep 2017 11:46:13 +0200 From: Boris Brezillon To: Richard Genoud Cc: linux-mtd , Nicolas Ferre , Linux Kernel Subject: Re: [PATCH] mtd: nand: atmel: fix buffer overflow in atmel_pmecc_user Message-ID: <20170928114613.653a4d50@bbrezillon> In-Reply-To: <1506516557.19393.5.camel@gmail.com> References: <1506516557.19393.5.camel@gmail.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1536 Lines: 42 On Wed, 27 Sep 2017 14:49:17 +0200 Richard Genoud wrote: > When calculating the size needed by struct atmel_pmecc_user *user, > the dmu and delta buffer sizes were forgotten. > This lead to a memory corruption (especially with a large ecc_strength). > > Link: http://lkml.kernel.org/r/1506503157.3016.5.camel@gmail.com > Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") > Cc: Nicolas Ferre > Cc: stable@vger.kernel.org > Reported-by: Richard Genoud > Pointed-at-by: Boris Brezillon > Signed-off-by: Richard Genoud Applied. Thanks, Boris > --- > drivers/mtd/nand/atmel/pmecc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c > index 146af8218314..8268636675ef 100644 > --- a/drivers/mtd/nand/atmel/pmecc.c > +++ b/drivers/mtd/nand/atmel/pmecc.c > @@ -363,7 +363,7 @@ atmel_pmecc_create_user(struct atmel_pmecc *pmecc, > size += (req->ecc.strength + 1) * sizeof(u16); > /* Reserve space for mu, dmu and delta. */ > size = ALIGN(size, sizeof(s32)); > - size += (req->ecc.strength + 1) * sizeof(s32); > + size += (req->ecc.strength + 1) * sizeof(s32) * 3; > > user = kzalloc(size, GFP_KERNEL); > if (!user) > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/