Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932082AbdI1K5I (ORCPT ); Thu, 28 Sep 2017 06:57:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42424 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752777AbdI1K5C (ORCPT ); Thu, 28 Sep 2017 06:57:02 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 09953C111D61 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=pbonzini@redhat.com Subject: Re: [PATCH v4 3/3] MAINTAINERS: xen, kvm: track pvclock-abi.h changes To: Konrad Rzeszutek Wilk , Joao Martins Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Boris Ostrovsky , Juergen Gross , Radim Krcmar , Andy Lutomirski References: <20170927134623.3147-1-joao.m.martins@oracle.com> <20170927134623.3147-4-joao.m.martins@oracle.com> <20170927160650.GI28001@char.us.oracle.com> From: Paolo Bonzini Message-ID: Date: Thu, 28 Sep 2017 12:56:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170927160650.GI28001@char.us.oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 28 Sep 2017 10:57:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1770 Lines: 51 On 27/09/2017 18:06, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 27, 2017 at 02:46:23PM +0100, Joao Martins wrote: >> This file defines an ABI shared between guest and hypervisor(s) >> (KVM, Xen) and as such there should be an correspondent entry in >> MAINTAINERS file. Notice that there's already a text notice at the >> top of the header file, hence this commit simply enforces it more >> explicitly and have both peers noticed when such changes happen. >> >> Signed-off-by: Joao Martins >> Acked-by: Juergen Gross > > Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Paolo Bonzini >> --- >> In the end, I choose the originally posted because this is so far the >> only ABI shared between Xen/KVM. Therefore whenever we have more things >> shared it would deserve its own place in MAINTAINERS file. If the >> thinking is wrong, I can switch to the alternative with a >> "PARAVIRT ABIS" section. >> >> Changes since v1: >> * Add Juergen Gross Acked-by. >> --- >> MAINTAINERS | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 6671f375f7fc..a4834c3c377a 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -7603,6 +7603,7 @@ S: Supported >> F: arch/x86/kvm/ >> F: arch/x86/include/uapi/asm/kvm* >> F: arch/x86/include/asm/kvm* >> +F: arch/x86/include/asm/pvclock-abi.h >> F: arch/x86/kernel/kvm.c >> F: arch/x86/kernel/kvmclock.c >> >> @@ -14718,6 +14719,7 @@ F: arch/x86/xen/ >> F: drivers/*/xen-*front.c >> F: drivers/xen/ >> F: arch/x86/include/asm/xen/ >> +F: arch/x86/include/asm/pvclock-abi.h >> F: include/xen/ >> F: include/uapi/xen/ >> F: Documentation/ABI/stable/sysfs-hypervisor-xen >> -- >> 2.11.0 >>