Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbdI1LMl (ORCPT ); Thu, 28 Sep 2017 07:12:41 -0400 Received: from a.mx.secunet.com ([62.96.220.36]:53932 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbdI1LMk (ORCPT ); Thu, 28 Sep 2017 07:12:40 -0400 Date: Thu, 28 Sep 2017 13:12:32 +0200 From: Steffen Klassert To: Florian Westphal CC: Artem Savkov , Herbert Xu , "David S . Miller" , , Subject: Re: [PATCH] xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock Message-ID: <20170928111232.GT3149@secunet.com> References: <20170927122537.14235-1-asavkov@redhat.com> <20170927123103.GB14971@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170927123103.GB14971@breakpoint.cc> User-Agent: Mutt/1.5.24 (2015-08-30) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: 0A9D1EE0-95B1-406A-8B24-742346818C6E Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 634 Lines: 15 On Wed, Sep 27, 2017 at 02:31:03PM +0200, Florian Westphal wrote: > Artem Savkov wrote: > > I might be wrong but it doesn't look like xfrm_state_lock is required > > for xfrm_policy_cache_flush and calling it under this lock triggers both > > "sleeping function called from invalid context" and "possible circular > > locking dependency detected" warnings on flush. > > > > Fixes: ec30d78c14a8 xfrm: add xdst pcpu cache > > Signed-off-by: Artem Savkov > > You're right, its not needed (and wrong). > > Acked-by: Florian Westphal Applied to the ipsec tree, thanks everyone!