Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752923AbdI1LvY (ORCPT ); Thu, 28 Sep 2017 07:51:24 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34017 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbdI1LvX (ORCPT ); Thu, 28 Sep 2017 07:51:23 -0400 X-Google-Smtp-Source: AOwi7QBTTUaa/RhbY5Ax1dJpIwNvyeHDZ4DvOFwKklGYlTUodZ8/hdlwarhmxiLqsJz8bL89cf9Yhw== Date: Thu, 28 Sep 2017 20:51:18 +0900 From: Sergey Senozhatsky To: Peter Zijlstra Cc: Sergey Senozhatsky , Sasha Levin , Thomas Gleixner , Ingo Molnar , "linux-kernel@vger.kernel.org List" , alexander.levin@verizon.com, pmladek@suse.com, sergey.senozhatsky@gmail.com, rostedt@goodmis.org Subject: Re: sched: serial port lockdep warning when offlining CPUs Message-ID: <20170928115118.GA687@jagdpanzerIV.localdomain> References: <20170928093847.zgcgvxb7ajiaywbr@hirez.programming.kicks-ass.net> <20170928103032.GA2380@jagdpanzerIV.localdomain> <20170928114705.4a2iaek26qcdo7qk@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170928114705.4a2iaek26qcdo7qk@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 32 On (09/28/17 13:47), Peter Zijlstra wrote: > On Thu, Sep 28, 2017 at 07:30:32PM +0900, Sergey Senozhatsky wrote: > > --- > > > > lib/ratelimit.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lib/ratelimit.c b/lib/ratelimit.c > > index 08f8043cac61..bddc55834c2e 100644 > > --- a/lib/ratelimit.c > > +++ b/lib/ratelimit.c > > @@ -48,7 +48,8 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func) > > if (time_is_before_jiffies(rs->begin + rs->interval)) { > > if (rs->missed) { > > if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) { > > - pr_warn("%s: %d callbacks suppressed\n", func, rs->missed); > > + printk_deferred(KERN_WARN "%s: %d callbacks suppressed\n", > > + func, rs->missed); > > rs->missed = 0; > > } > > } > > Oh cute; I figured it was the syslog daemon suppressing multiple > identical lines, but yes the above looks very plausible. seems to be stable v4.8+ material. Fixes: 6b1d174b0c27b ("ratelimit: extend to print suppressed messages on release") I'll send out a patch. -ss