Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752928AbdI1MP1 (ORCPT ); Thu, 28 Sep 2017 08:15:27 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:49488 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752359AbdI1MP0 (ORCPT ); Thu, 28 Sep 2017 08:15:26 -0400 X-Google-Smtp-Source: AOwi7QAoHinNlhkmgT+tf6SX8IRYGovuidecHGX7LOrtqlNsYGSDxk+S9jtCe5EWhlTUZ6EpGaErPg== Date: Thu, 28 Sep 2017 21:15:21 +0900 From: Sergey Senozhatsky To: Peter Zijlstra Cc: "Levin, Alexander (Sasha Levin)" , Sergey Senozhatsky , Sasha Levin , Thomas Gleixner , Ingo Molnar , "linux-kernel@vger.kernel.org List" , "pmladek@suse.com" , "sergey.senozhatsky@gmail.com" , "rostedt@goodmis.org" Subject: Re: sched: serial port lockdep warning when offlining CPUs Message-ID: <20170928121521.GD687@jagdpanzerIV.localdomain> References: <20170928093847.zgcgvxb7ajiaywbr@hirez.programming.kicks-ass.net> <20170928103032.GA2380@jagdpanzerIV.localdomain> <20170928113607.GB30818@jagdpanzerIV.localdomain> <20170928114528.wilknwkyjecqrcaa@sasha-lappy> <20170928120532.cjidduvjj5xygaid@hirez.programming.kicks-ass.net> <20170928120722.ir5tcclsg336ou2n@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170928120722.ir5tcclsg336ou2n@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 620 Lines: 20 On (09/28/17 14:07), Peter Zijlstra wrote: [..] > > Nah.. WARN's _should_ not trigger. If they do we fix that. > > > > Getting a lockdep splat after a WARN is something I can live with. > > > > And you really don't want that deferred nonsense for WARNs, because that > > means you'll risk not over getting the output. > > Note that I'm not likely to care too much either way, because I'm simply > not using any of that printk() nonsense ;-) > > > I'll repost my patches now; otherwise I'll forget again anyway. #define printk printk_deferred should also do the trick and... make the kernel great again! :) -ss