Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753336AbdI1PLM (ORCPT ); Thu, 28 Sep 2017 11:11:12 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:51514 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbdI1PLK (ORCPT ); Thu, 28 Sep 2017 11:11:10 -0400 X-Google-Smtp-Source: AOwi7QDKB1B5b3MT6LwnfwPWLJ3oiYKuxYffpmmY4ND9bgVZHEIDfePq1YK/D6r0iB/rVGKKjnX4ax+5JjpgNFw46bE= MIME-Version: 1.0 In-Reply-To: References: <20170927172802.80654-1-grundler@chromium.org> From: Doug Anderson Date: Thu, 28 Sep 2017 08:11:07 -0700 X-Google-Sender-Auth: _-_29AhwLvNlqICIvvfCp4j9KSg Message-ID: Subject: Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id To: Grant Grundler Cc: Hayes Wang , Oliver Neukum , linux-usb , "David S . Miller" , LKML , netdev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 20 Hi, On Wed, Sep 27, 2017 at 5:07 PM, Grant Grundler wrote: >>> #define DELL_VENDOR_ID 0x413C >>> #define REALTEK_VENDOR_ID 0x0bda >>> #define SAMSUNG_VENDOR_ID 0x04e8 >>> +#define LINKSYS_VENDOR_ID 0x13b1 >>> #define LENOVO_VENDOR_ID 0x17ef >> >> Slight nit that "LI" sorts after "LE". You got it right in the other case... > > The list isn't sorted by any rational thing I can see. I managed to > check my OCD reaction to sort the list numerically. :) Whoops, you're right. It seems to be in a random order. I just saw LE, LI, and N sorted properly and jumped to a conclusion. In any case, if it's all the same to you it'd be nice if you were consistent between LENOVO/LINKSYS in the two files. :-P -Doug