Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751754AbdI1QMY (ORCPT ); Thu, 28 Sep 2017 12:12:24 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38162 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbdI1QMW (ORCPT ); Thu, 28 Sep 2017 12:12:22 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 682086044E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH 1/4] pci: introduce __pci_walk_bus for caller with pci_bus_sem held To: Govindarajulu Varadarajan , benve@cisco.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, jlbec@evilplan.org, hch@lst.de, mingo@redhat.com, peterz@infradead.org References: <20170927214220.41216-1-gvaradar@cisco.com> <20170927214220.41216-2-gvaradar@cisco.com> From: Sinan Kaya Message-ID: <5bbeefd2-a409-168c-b596-bcaa29a54eb7@codeaurora.org> Date: Thu, 28 Sep 2017 12:12:19 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170927214220.41216-2-gvaradar@cisco.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 470 Lines: 11 On 9/27/2017 5:42 PM, Govindarajulu Varadarajan wrote: > +void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *), > + void *userdata); pci_walk_bus_locked would be a better name as you are assuming that caller is holding the lock. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.