Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752042AbdI1QcZ (ORCPT ); Thu, 28 Sep 2017 12:32:25 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:48238 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbdI1QcX (ORCPT ); Thu, 28 Sep 2017 12:32:23 -0400 Date: Thu, 28 Sep 2017 09:32:20 -0700 (PDT) Message-Id: <20170928.093220.2223492078191370005.davem@davemloft.net> To: mengxu.gatech@gmail.com Cc: mac@melware.de, isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, meng.xu@gatech.edu, sanidhya@gatech.edu, taesoo@gatech.edu Subject: Re: [PATCH] isdn/eicon: do integrity check on cmd->adapter == a->controller early From: David Miller In-Reply-To: <1506266081-22895-1-git-send-email-mengxu.gatech@gmail.com> References: <1506266081-22895-1-git-send-email-mengxu.gatech@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 Sep 2017 09:32:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 652 Lines: 19 From: Meng Xu Date: Sun, 24 Sep 2017 11:14:41 -0400 > + /* do the integrity check early */ > + if(((diva_xdi_um_cfg_cmd_t *)data)->adapter != a->controller){ > + DBG_ERR(("A: A(%d) write, invalid controller=%d != %d", > + ((diva_xdi_um_cfg_cmd_t *)data)->adapter, a->controller)); > + DBG_ERR() has a trailing semicolon in it's definition, so if you add another one when you invoke it there will be two ";;". This whole code base is such a mess, I really think there is little to no value in trying to make minor changes here. So unless you are fixing some kind of exploitable hole, please drop this. Thank you.