Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752186AbdI1QdG (ORCPT ); Thu, 28 Sep 2017 12:33:06 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:45102 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbdI1QdF (ORCPT ); Thu, 28 Sep 2017 12:33:05 -0400 From: Vivien Didelot To: Brandon Streiff , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Florian Fainelli , Andrew Lunn , Richard Cochran , Erik Hons , Brandon Streiff Subject: Re: [PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers In-Reply-To: <1506612341-18061-2-git-send-email-brandon.streiff@ni.com> References: <1506612341-18061-1-git-send-email-brandon.streiff@ni.com> <1506612341-18061-2-git-send-email-brandon.streiff@ni.com> Date: Thu, 28 Sep 2017 12:29:24 -0400 Message-ID: <87o9puaisb.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 790 Lines: 26 Hi Brandon, Brandon Streiff writes: > + .port_ptp_read = mv88e6352_port_ptp_read, > + .port_ptp_write = mv88e6352_port_ptp_write, > + .ptp_read = mv88e6352_ptp_read, > + .ptp_write = mv88e6352_ptp_write, > + .tai_read = mv88e6352_tai_read, > + .tai_write = mv88e6352_tai_write, > + .port_ptp_read = mv88e6390_port_ptp_read, > + .port_ptp_write = mv88e6390_port_ptp_write, > + .ptp_read = mv88e6390_ptp_read, > + .ptp_write = mv88e6390_ptp_write, > + .tai_read = mv88e6390_tai_read, > + .tai_write = mv88e6390_tai_write, Only nitpick: please keep the mv88e63{52,90}_g2_avb_ prefix here. Otherwise thanks for respecting the code organization, very clear patch: Reviewed-by: Vivien Didelot Vivien