Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752028AbdI1Q4Y (ORCPT ); Thu, 28 Sep 2017 12:56:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41255 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbdI1Q4V (ORCPT ); Thu, 28 Sep 2017 12:56:21 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 62CB3165316 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=ddutile@redhat.com Subject: Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support To: David Woodhouse , Alexander Duyck References: <1506517162.30379.2.camel@infradead.org> <20170927220005.GB23674@bhelgaas-glaptop.roam.corp.google.com> <1506550852.7476.33.camel@infradead.org> <1506606369.7476.96.camel@infradead.org> <7bbb6cce-3462-fbb2-9ae4-5c08ab2b01b4@redhat.com> <1506613946.7476.130.camel@infradead.org> Cc: Bjorn Helgaas , Greg Kroah-Hartman , linux-pci , linux-kernel , Alexander Duyck , "Bryant G. Ly" , Bodong Wang , Alex Williamson , "Michael S. Tsirkin" , kvm@vger.kernel.org From: Don Dutile Message-ID: <3ddc65bd-bf47-acb8-4cc5-db2531e1e864@redhat.com> Date: Thu, 28 Sep 2017 12:56:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1506613946.7476.130.camel@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 28 Sep 2017 16:56:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 24 On 09/28/2017 11:52 AM, David Woodhouse wrote: > On Thu, 2017-09-28 at 11:05 -0400, Don Dutile wrote: >> ah, nickel summary: no in-kernel driver w/.sriov-configure method. >> if so, now I'm up to speed with you.... >> hmmmm.... >> so, that would imply we need an in-kernel, pcie-common, .sriov- >> configure method >> that's invoked if a driver isn't bound to a device? ... yes? > > Well that was kind of the point in my question below the --- > > Is that something we want to be generic? Would we want to have quirks > for the devices where we might *not* want it? > > Anything that *has* a driver for the PF, should have .sriov_configure > already. Anything that doesn't have a driver can (now) use UIO to > enable SR-IOV. So we don't *have* to make it unconditionally > available... > Well, my point is more like: why put it in uio? why not make it available via pcie, setup while/if no driver attached? i.e., other non-uio users can use the mechanism.... like libvirt? ... if a PF driver isn't required.