Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752370AbdI1R3K (ORCPT ); Thu, 28 Sep 2017 13:29:10 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:50000 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752000AbdI1R3I (ORCPT ); Thu, 28 Sep 2017 13:29:08 -0400 Date: Thu, 28 Sep 2017 10:29:07 -0700 (PDT) Message-Id: <20170928.102907.1277678452927871516.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing IRQs From: David Miller In-Reply-To: <20170926185721.12187-1-vivien.didelot@savoirfairelinux.com> References: <20170926185721.12187-1-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 Sep 2017 10:29:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 477 Lines: 11 From: Vivien Didelot Date: Tue, 26 Sep 2017 14:57:21 -0400 > mv88e6xxx_g2_irq_free locks the registers mutex, but not > mv88e6xxx_g1_irq_free, which results in a stack trace from > assert_reg_lock when unloading the mv88e6xxx module. Fix this. > > Fixes: 3460a5770ce9 ("net: dsa: mv88e6xxx: Mask g1 interrupts and free interrupt") > Signed-off-by: Vivien Didelot Applied and queued up for -stable.