Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752375AbdI1Rgd (ORCPT ); Thu, 28 Sep 2017 13:36:33 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60219 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027AbdI1Rgc (ORCPT ); Thu, 28 Sep 2017 13:36:32 -0400 Date: Thu, 28 Sep 2017 19:36:29 +0200 From: Andrew Lunn To: Brandon Streiff Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Florian Fainelli , Vivien Didelot , Richard Cochran , Erik Hons Subject: Re: [PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx Message-ID: <20170928173629.GD14940@lunn.ch> References: <1506612341-18061-1-git-send-email-brandon.streiff@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506612341-18061-1-git-send-email-brandon.streiff@ni.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 776 Lines: 19 > - Patch #3: The GPIO config support is handled in a very simple manner. > I suspect a longer term goal would be to use pinctrl here. I assume ptp already has the core code to use pinctrl and Linux standard GPIOs? What does the device tree binding look like? How do you specify the GPIOs to use? What we want to avoid is defining an ABI now, otherwise it is going to be hard to swap to pinctrl later. > - Patch #6: the dsa_switch pointer and port index is plumbed from > dsa_device_ops::rcv so that we can call the correct port_rxtstamp > method. This involved instrumenting all of the *_tag_rcv functions in > a way that's kind of a kludge and that I'm not terribly happy with. Yes, this is ugly. I will see if i can find a better way to do this. Andrew