Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751580AbdI1TSL (ORCPT ); Thu, 28 Sep 2017 15:18:11 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38026 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbdI1TSI (ORCPT ); Thu, 28 Sep 2017 15:18:08 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DEE5860708 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org X-Google-Smtp-Source: AOwi7QDN8VESbQthAASqQEyhiwowHV5pC/iPfXgc54gqzVUXsaVB4ldElcsm8NaJ7q6GzoGeVr6Bmy3sXJa1K65MX0U= MIME-Version: 1.0 In-Reply-To: <1506527369-19535-2-git-send-email-will.deacon@arm.com> References: <1506527369-19535-1-git-send-email-will.deacon@arm.com> <1506527369-19535-2-git-send-email-will.deacon@arm.com> From: Timur Tabi Date: Thu, 28 Sep 2017 14:18:05 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 1/2] arm64: mm: Use READ_ONCE/WRITE_ONCE when accessing page tables To: Will Deacon Cc: Peter Zijlstra , paulmck@linux.vnet.ibm.com, kirill.shutemov@linux.intel.com, lkml , Yury Norov , rruigrok@codeaurora.org, linux-arch@vger.kernel.org, "akpm@linux-foundation.org" , Catalin Marinas Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 515 Lines: 9 On Wed, Sep 27, 2017 at 10:49 AM, Will Deacon wrote: > This patch consistently uses these macros in the arch > code, as well as explicitly namespacing pointers to page table entries > from the entries themselves by using adopting a 'p' suffix for the former > (as is sometimes used elsewhere in the kernel source). Would you consider splitting up this patch into two, where the second patch makes all the cosmetic changes? That would make the "meatier" patch easier to back-port and review.