Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751672AbdI1UBc (ORCPT ); Thu, 28 Sep 2017 16:01:32 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:58508 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbdI1UBb (ORCPT ); Thu, 28 Sep 2017 16:01:31 -0400 From: Vivien Didelot To: Andrew Lunn , Florian Fainelli Cc: Brandon Streiff , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Richard Cochran , Erik Hons Subject: Re: [PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration In-Reply-To: <20170928180111.GF14940@lunn.ch> References: <1506612341-18061-1-git-send-email-brandon.streiff@ni.com> <1506612341-18061-4-git-send-email-brandon.streiff@ni.com> <659c4254-d0b7-52dc-dd9b-3921cd2f20c0@gmail.com> <20170928180111.GF14940@lunn.ch> Date: Thu, 28 Sep 2017 15:57:51 -0400 Message-ID: <87k20izjcw.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 469 Lines: 16 Hi Brandon, >> Would there be any value in implementing a proper gpiochip structure >> here such that other pieces of SW can see this GPIO controller as a >> provider and you can reference it from e.g: Device Tree using GPIO >> descriptors? > > That would be my preference as well, or maybe a pinctrl driver. Indeed seeing a gpio_chip or a pinctrl controller registered from a gpio.c or pinctrl.c file in a separate patchset would be great. Thanks, Vivien