Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752050AbdI1XxS (ORCPT <rfc822;w@1wt.eu>);
        Thu, 28 Sep 2017 19:53:18 -0400
Received: from alln-iport-2.cisco.com ([173.37.142.89]:35118 "EHLO
        alln-iport-2.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751967AbdI1XxO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 28 Sep 2017 19:53:14 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CoAQDCis1Z/4cNJK1dGQEBAQEBAQEBA?=
 =?us-ascii?q?QEBBwEBAQEBg1yBUi6dcIFUIpg9CoU7AoQlVwECAQEBAQECayiFGAEBAQECATg?=
 =?us-ascii?q?CPwULCw4KLjwbBg6KKQUIqUCLQwEBAQEBAQEBAQEBAQEBAQEBASCDK4ICgVGCI?=
 =?us-ascii?q?IJyincFkT2BD45cllsBkQpIlFgCERkBgTlXgQ54FYVjHIIHh3sBgQ8BAQE?=
X-IronPort-AV: E=Sophos;i="5.42,451,1500940800"; 
   d="scan'208";a="10196403"
Date: Thu, 28 Sep 2017 16:52:55 -0700
From: Govindarajulu Varadarajan <gvaradar@cisco.com>
To: Sinan Kaya <okaya@codeaurora.org>
CC: <benve@cisco.com>, <bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <jlbec@evilplan.org>, <hch@lst.de>,
        <mingo@redhat.com>, <peterz@infradead.org>
Subject: Re: [PATCH 1/4] pci: introduce __pci_walk_bus for caller with
 pci_bus_sem held
In-Reply-To: <5bbeefd2-a409-168c-b596-bcaa29a54eb7@codeaurora.org>
Message-ID: <alpine.LNX.2.20.1709281652280.24635@cae-iprp-alln-lb.cisco.com>
References: <20170927214220.41216-1-gvaradar@cisco.com> <20170927214220.41216-2-gvaradar@cisco.com> <5bbeefd2-a409-168c-b596-bcaa29a54eb7@codeaurora.org>
User-Agent: Alpine 2.20 (LNX 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"; format=flowed
X-Originating-IP: [10.157.132.141]
X-ClientProxiedBy: xch-aln-006.cisco.com (173.36.7.16) To
 XCH-RCD-012.cisco.com (173.37.102.22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 344
Lines: 11

On Thu, 28 Sep 2017, Sinan Kaya wrote:

> On 9/27/2017 5:42 PM, Govindarajulu Varadarajan wrote:
>> +void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *),
>> +		    void *userdata);
>
> pci_walk_bus_locked would be a better name as you are assuming that caller is
> holding the lock.
>

Will change and resubmit for v2.