Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752097AbdI1Xxk (ORCPT ); Thu, 28 Sep 2017 19:53:40 -0400 Received: from mail-wr0-f177.google.com ([209.85.128.177]:55096 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbdI1Xxh (ORCPT ); Thu, 28 Sep 2017 19:53:37 -0400 X-Google-Smtp-Source: AOwi7QBjub5jRNTdPYwlBr3grfvRih12+ME7l7KIMy8vv9Wwrt7ef5U76ulX+N9kI30z0lg14meJ9+N5jTUaDkBAUiE= MIME-Version: 1.0 In-Reply-To: References: <20170926010925.114436-1-grundler@chromium.org> <1506496556.28482.3.camel@suse.com> From: Doug Anderson Date: Thu, 28 Sep 2017 16:53:35 -0700 X-Google-Sender-Auth: aXhZ-DSgwdDN8N9lZgDc7QVE1rk Message-ID: Subject: Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id To: "Rustad, Mark D" Cc: Grant Grundler , Oliver Neukum , "David S . Miller" , Greg Kroah-Hartman , Hayes Wang , LKML , linux-usb , netdev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1426 Lines: 35 Hi, On Thu, Sep 28, 2017 at 3:28 PM, Rustad, Mark D wrote: > >> On Sep 27, 2017, at 9:39 AM, Grant Grundler wrote: >> >> On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum wrote: >>> Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: >>>> >>>> I know that for at least some of the adapters in the CDC Ethernet >>>> blacklist it was claimed that the CDC Ethernet support in the adapter >>>> was kinda broken anyway so the blacklist made sense. ...but for the >>>> Linksys Gigabit adapter the CDC Ethernet driver seems to work OK, it's >>>> just not quite as full featured / efficient as the R8152 driver. >>>> >>>> Is that not a concern? I guess you could tell people in this >>>> situation that they simply need to enable the R8152 driver to get >>>> continued support for their Ethernet adapter? >>> >>> Hi, >>> >>> yes, it is a valid concern. An #ifdef will be needed. >> >> Good idea - I will post V3 shortly. >> >> I'm assuming you mean to add #ifdef CONFIG_USB_RTL8152 around the >> blacklist entry in cdc_ether driver. > > Shouldn't that be an #if IS_ENABLED(...) test, since that seems to be the proper way to check configured drivers. Yes, I had the same feedback on v3. See my comments at . Grant has fixed it in v4. Please see . :) -Doug