Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751914AbdI2HJo (ORCPT ); Fri, 29 Sep 2017 03:09:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:60772 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750932AbdI2HJn (ORCPT ); Fri, 29 Sep 2017 03:09:43 -0400 Subject: Re: [PATCH v3] mm, sysctl: make NUMA stats configurable To: Andrew Morton , Kemi Wang Cc: "Luis R . Rodriguez" , Kees Cook , Jonathan Corbet , Michal Hocko , Mel Gorman , Johannes Weiner , Christopher Lameter , Sebastian Andrzej Siewior , Dave , Tim Chen , Andi Kleen , Jesper Dangaard Brouer , Ying Huang , Aaron Lu , Proc sysctl , Linux MM , Linux Kernel References: <1506579101-5457-1-git-send-email-kemi.wang@intel.com> <20170928142950.1a09090fe4baf4acdc1bbc35@linux-foundation.org> From: Vlastimil Babka Message-ID: Date: Fri, 29 Sep 2017 09:09:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170928142950.1a09090fe4baf4acdc1bbc35@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1126 Lines: 27 On 09/28/2017 11:29 PM, Andrew Morton wrote: > On Thu, 28 Sep 2017 14:11:41 +0800 Kemi Wang wrote: > >> This is the second step which introduces a tunable interface that allow >> numa stats configurable for optimizing zone_statistics(), as suggested by >> Dave Hansen and Ying Huang. > > Looks OK I guess. > > I fiddled with it a lot. Please consider: > > From: Andrew Morton > Subject: mm-sysctl-make-numa-stats-configurable-fix > > - tweak documentation > > - move advisory message from start_kernel() into mm_init() (I'm not sure > we really need this message) Actually, I'm not sure we need any of the current messages, or to have them at higher priority than pr_debug()? They are all triggered by admin action, or unconditionally upon boot. OTOH I think that an useful message that's currently missing would be when the static_key_enable() is triggered in auto mode. Bonus points for including the name of the process and the stat file that was read. However static_key_enable() returns void and not whether it actually flipped the switch, so it's not trivial.