Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752100AbdI2LL6 (ORCPT ); Fri, 29 Sep 2017 07:11:58 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:37075 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbdI2LL4 (ORCPT ); Fri, 29 Sep 2017 07:11:56 -0400 X-Google-Smtp-Source: AOwi7QCVgCYR3rwjuPKcrddtIeOlTVazgvsnCRdp1w4v6IhH1T+qsCUV1QkydVFy7nlxzYCUQ28iMQ== Subject: Re: [PATCH v3] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings To: Chaotian Jing , Rob Herring Cc: Ulf Hansson , Mark Rutland , Catalin Marinas , Will Deacon , yong mao , Linus Walleij , Javier Martinez Canillas , Heiner Kallweit , Phong LE , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com References: <1506081829-29296-1-git-send-email-chaotian.jing@mediatek.com> From: Matthias Brugger Message-ID: Date: Fri, 29 Sep 2017 13:11:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1506081829-29296-1-git-send-email-chaotian.jing@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2487 Lines: 57 On 09/22/2017 02:03 PM, Chaotian Jing wrote: > Change the comptiable for support of multi-platform > Add description for reg > Add description for source_cg > Add description for mediatek,latch-ck > Note that source_cg and mediatek,latch-ck are optional for some projects, > eg, MT2701 do not have source_cg, and MT2712 do not need > mediatek,latch-ck > > Signed-off-by: Chaotian Jing > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > index 4182ea3..b934a29 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -7,10 +7,15 @@ This file documents differences between the core properties in mmc.txt > and the properties used by the msdc driver. > > Required properties: > -- compatible: Should be "mediatek,mt8173-mmc","mediatek,mt8135-mmc" > +- compatible: value should be either of the following. > + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 > + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > + "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > + "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 NAK, this has to be: You have to add the fallback comatible ("mediatek,mt8135-mmc") to the binding description as otherwise the driver does not get probed. Regards, Matthias > +- reg: physical base address of the controller and length > - interrupts: Should contain MSDC interrupt number > -- clocks: MSDC source clock, HCLK > -- clock-names: "source", "hclk" > +- clocks: MSDC source clock, HCLK, source_cg > +- clock-names: "source", "hclk", "source_cg" > - pinctrl-names: should be "default", "state_uhs" > - pinctrl-0: should contain default/high speed pin ctrl > - pinctrl-1: should contain uhs mode pin ctrl > @@ -30,6 +35,8 @@ Optional properties: > - mediatek,hs400-cmd-resp-sel-rising: HS400 command response sample selection > If present,HS400 command responses are sampled on rising edges. > If not present,HS400 command responses are sampled on falling edges. > +- mediatek,latch-ck: Some SoCs do not support enhance_rx, need set correct latch-ck to avoid data crc > + error caused by stop clock(fifo full) > > Examples: > mmc0: mmc@11230000 { >