Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752178AbdI2Lad (ORCPT ); Fri, 29 Sep 2017 07:30:33 -0400 Received: from [213.95.27.120] ([213.95.27.120]:59547 "EHLO ganesha.gnumonks.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751590AbdI2Lab (ORCPT ); Fri, 29 Sep 2017 07:30:31 -0400 Date: Fri, 29 Sep 2017 13:29:18 +0200 From: Pablo Neira Ayuso To: Artem Savkov Cc: Florian Westphal , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH v3] ebtables: fix race condition in frame_filter_net_init() Message-ID: <20170929112918.GA6066@salvia> References: <20170926153923.30094-1-asavkov@redhat.com> <20170926163545.3668-1-asavkov@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170926163545.3668-1-asavkov@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 252 Lines: 6 On Tue, Sep 26, 2017 at 06:35:45PM +0200, Artem Savkov wrote: > It is possible for ebt_in_hook to be triggered before ebt_table is assigned > resulting in a NULL-pointer dereference. Make sure hooks are > registered as the last step. Applied, thanks.