Subject: Re: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Steven Rostedt <rostedt@goodmis.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <765df45e-18f0-3d3d-29c6-42f850b3b826@siemens.com>
Message-ID: <4f7bc629-b05f-4de8-f674-915f8dc72a14@siemens.com>
Date: Fri, 29 Sep 2017 13:49:31 +0200
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12)
 Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666
MIME-Version: 1.0
In-Reply-To: <765df45e-18f0-3d3d-29c6-42f850b3b826@siemens.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1155
Lines: 38

On 2017-09-29 13:29, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> I didn't manage to test this so far, but this looked strange while
> reading the code.

Now I found out how it is supposed to work and can confirm that this
patch fixes a real bug.

Jan

> 
>  trace-view-store.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/trace-view-store.c b/trace-view-store.c
> index 2ec52c8..f5d0a04 100644
> --- a/trace-view-store.c
> +++ b/trace-view-store.c
> @@ -1254,7 +1254,7 @@ static void update_filter_tasks(TraceViewStore *store)
>  						      "pid");
>  
>  		store->sched_wakeup_new_event =
> -			pevent_find_event_by_name(pevent, "sched", "sched_wakeup");
> +			pevent_find_event_by_name(pevent, "sched", "sched_wakeup_new");
>  		if (store->sched_wakeup_new_event)
>  			store->sched_wakeup_new_pid_field =
>  				pevent_find_any_field(store->sched_wakeup_new_event,
> 

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux