Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752154AbdI2NrQ (ORCPT ); Fri, 29 Sep 2017 09:47:16 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:16404 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbdI2NrO (ORCPT ); Fri, 29 Sep 2017 09:47:14 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 29 Sep 2017 06:46:59 -0700 Subject: Re: [PATCH 2/4] clk: tegra: check BPMP response return code To: Jonathan Hunter , "thierry.reding@gmail.com" CC: "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <6a69e270519fd1c7a12a335053bf59671abc3c4b.1504776489.git.talho@nvidia.com> <388e07bc-b7b4-cc17-026a-bd08d77942ca@nvidia.com> From: Timo Alho X-Nvconfidentiality: public Message-ID: Date: Fri, 29 Sep 2017 16:46:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <388e07bc-b7b4-cc17-026a-bd08d77942ca@nvidia.com> X-Originating-IP: [10.21.24.139] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2083 Lines: 60 Hi Jon, On 21.09.2017 14:21, Jonathan Hunter wrote: > > > On 07/09/17 10:31, Timo Alho wrote: >> Check return code in BPMP response message(s). The typical error case >> is when clock operation is attempted with invalid clock identifier. >> >> Also remove error print from call to clk_get_info() as the >> implementation loops through range of all possible identifier, but the >> operation is expected error out when the clock id is unused. >> >> Signed-off-by: Timo Alho >> --- >> drivers/clk/tegra/clk-bpmp.c | 15 ++++++++++----- >> 1 file changed, 10 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/clk/tegra/clk-bpmp.c b/drivers/clk/tegra/clk-bpmp.c >> index 638ace6..a896692 100644 >> --- a/drivers/clk/tegra/clk-bpmp.c >> +++ b/drivers/clk/tegra/clk-bpmp.c >> @@ -55,6 +55,7 @@ struct tegra_bpmp_clk_message { >> struct { >> void *data; >> size_t size; >> + int ret; >> } rx; >> }; >> >> @@ -64,6 +65,7 @@ static int tegra_bpmp_clk_transfer(struct tegra_bpmp *bpmp, >> struct mrq_clk_request request; >> struct tegra_bpmp_message msg; >> void *req = &request; >> + int err; >> >> memset(&request, 0, sizeof(request)); >> request.cmd_and_id = (clk->cmd << 24) | clk->id; >> @@ -84,7 +86,13 @@ static int tegra_bpmp_clk_transfer(struct tegra_bpmp *bpmp, >> msg.rx.data = clk->rx.data; >> msg.rx.size = clk->rx.size; >> >> - return tegra_bpmp_transfer(bpmp, &msg); >> + err = tegra_bpmp_transfer(bpmp, &msg); >> + if (err < 0) >> + return err; >> + else if (msg.rx.ret < 0) >> + return -EINVAL; > > I assume that the error codes returned do not correlated to the Linux > error codes here. Is that correct? If not we could just return the > actual error code. Otherwise would it be useful to print a message with > the bpmp error code for debug? The error codes are not 1:1 match with Linux. Unfortunately, printing message for debug is not either viable as during clock probing we are expecting many of the calls to return -BPMP_EINVAL to indicate that particular clock ID is unused. -Timo