Date: Fri, 29 Sep 2017 16:55:54 +0300
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Alexandru Moise <00moses.alexander00@gmail.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com,
        aneesh.kumar@linux.vnet.ibm.com, n-horiguchi@ah.jp.nec.com,
        mike.kravetz@oracle.com, khandual@linux.vnet.ibm.com,
        punit.agrawal@arm.com, gerald.schaefer@de.ibm.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/madvise: enable soft offline of HugeTLB pages at PUD
 level
Message-ID: <20170929135554.6cz7lpjn7gepmlf4@node.shutemov.name>
References: <20170913101047.GA13026@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170913101047.GA13026@gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 788
Lines: 19

On Wed, Sep 13, 2017 at 12:10:47PM +0200, Alexandru Moise wrote:
> since 94310cb we've been able to soft offline 1G hugepages at the PGD
> level, however x86_64 gigantic hugepages are at the PUD level so we
> should add an extra check to account for hstate order at PUD level.

Have you tested other cases affected by the change? It allows migration of
1G pages in general, which might be problematic.

It also makes these pages allocated with GFP_HIGHUSER_MOVABLE instead of
GFP_HIGHUSER. Any side effects there we should consider?

> I'm not sure if this also applies to 5 level page tables on x86_64
> however. Tested with 4 level pagetable.

There's nothing changed in this regard in 5-level paging mode. PUD is
still one gig and there are no new page sizes.

-- 
 Kirill A. Shutemov