Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752338AbdI2PFS (ORCPT ); Fri, 29 Sep 2017 11:05:18 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:59338 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752193AbdI2PFR (ORCPT ); Fri, 29 Sep 2017 11:05:17 -0400 From: Philippe CORNU To: Benjamin Gaignard , "architt@codeaurora.org" , "a.hajda@samsung.com" , "Laurent.pinchart@ideasonboard.com" , "airlied@linux.ie" , "daniel.vetter@intel.com" , "jani.nikula@linux.intel.com" , "seanpaul@chromium.org" , Yannick FERTRE CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/3] Simplify panel bridge cleanup Thread-Topic: [PATCH 0/3] Simplify panel bridge cleanup Thread-Index: AQHTOSLMj4pAR6sSHEax5J05s3n2jqLL1IgA Date: Fri, 29 Sep 2017 15:03:54 +0000 Message-ID: <52057df2-c7bd-cdc8-9fee-d4b8b1b5acf8@st.com> References: <1506689959-7858-1-git-send-email-benjamin.gaignard@linaro.org> In-Reply-To: <1506689959-7858-1-git-send-email-benjamin.gaignard@linaro.org> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.49] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-29_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8TF5Wlg028975 Content-Length: 1351 Lines: 33 Hi Benjamin, and many thanks for this cleanup patchset. Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu Philippe :-) On 09/29/2017 02:59 PM, Benjamin Gaignard wrote: > The goal of this series is to simplify driver code when they need to clean up > a previously allocated panel bridge. > Few drivers have "is_panel_bridge" flag to be able to distinguish a > drm_panel_bridge from "simple" drm_bridge. > To remove this flag I propose to > - let drm_panel_bridge_remove() check if the bridge provided in parameter is > really a drm_panel_bridge. > - add drm_of_panel_bridge_remove() to remove a bridge given DT port and > endpoint > Finally that allow to remove drm_bridge structure and "is_panel_bridge" flag > from stm driver internal structure. > > Benjamin Gaignard (3): > drm/bridge: make drm_panel_bridge_remove more robust > drm/drm_of: add drm_of_panel_bridge_remove function > drm/stm: ltdc: remove bridge from driver internal structure > > drivers/gpu/drm/bridge/panel.c | 10 +++++++++- > drivers/gpu/drm/drm_of.c | 33 +++++++++++++++++++++++++++++++++ > drivers/gpu/drm/stm/ltdc.c | 16 +++++----------- > drivers/gpu/drm/stm/ltdc.h | 2 -- > include/drm/drm_of.h | 8 ++++++++ > 5 files changed, 55 insertions(+), 14 deletions(-) >