Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752562AbdI2PUT (ORCPT ); Fri, 29 Sep 2017 11:20:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34070 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752303AbdI2PUS (ORCPT ); Fri, 29 Sep 2017 11:20:18 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E6E9985541 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dledford@redhat.com Message-ID: <1506698416.2919.14.camel@redhat.com> Subject: Re: [PATCH] IB/qib: Use setup_timer and mod_timer From: Doug Ledford To: Himanshu Jha Cc: infinipath@intel.com, sean.hefty@intel.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 29 Sep 2017 11:20:16 -0400 In-Reply-To: <1506253867-5132-1-git-send-email-himanshujha199640@gmail.com> References: <1506253867-5132-1-git-send-email-himanshujha199640@gmail.com> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 29 Sep 2017 15:20:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 612 Lines: 26 On Sun, 2017-09-24 at 17:21 +0530, Himanshu Jha wrote: > Use setup_timer and mod_timer API instead of structure assignments. > > This is done using Coccinelle and semantic patch used > for this as follows: > > @@ > expression x,y,z,a,b; > @@ > > -init_timer (&x); > +setup_timer (&x, y, z); > +mod_timer (&a, b); > -x.function = y; > -x.data = z; > -x.expires = b; > -add_timer(&a); > > Signed-off-by: Himanshu Jha Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD