Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752463AbdI2PY6 (ORCPT ); Fri, 29 Sep 2017 11:24:58 -0400 Received: from foss.arm.com ([217.140.101.70]:45192 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752092AbdI2PY5 (ORCPT ); Fri, 29 Sep 2017 11:24:57 -0400 Date: Fri, 29 Sep 2017 16:24:55 +0100 From: Liviu Dudau To: Srishti Sharma Cc: daniel.vetter@ffwll.ch, seanpaul@chromium.org, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [PATCH] drm/arm: Replace instances of drm_dev_unref with drm_dev_put. Message-ID: <20170929152455.GL6681@e110455-lin.cambridge.arm.com> References: <1506679240-7061-1-git-send-email-srishtishar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1506679240-7061-1-git-send-email-srishtishar@gmail.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2318 Lines: 88 Hi Srishti, On Fri, Sep 29, 2017 at 03:30:40PM +0530, Srishti Sharma wrote: > Replace drm_dev_unref with drm_dev_put as it is more consistent > with kernel coding style. Done using the following semantic > patch by coccinelle. Thanks for the patch! Acked-by: Liviu Dudau I'm going to pull this patch into the mali-dp tree next week when I'm preparing an update of that tree. Best regards, Liviu > > @r@ > expression e; > @@ > > -drm_dev_unref(); > +drm_dev_put(); > > Signed-off-by: Srishti Sharma > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 4 ++-- > drivers/gpu/drm/arm/malidp_drv.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c > index f9bda7b..1a96462 100644 > --- a/drivers/gpu/drm/arm/hdlcd_drv.c > +++ b/drivers/gpu/drm/arm/hdlcd_drv.c > @@ -353,7 +353,7 @@ static int hdlcd_drm_bind(struct device *dev) > err_free: > drm_mode_config_cleanup(drm); > dev_set_drvdata(dev, NULL); > - drm_dev_unref(drm); > + drm_dev_put(drm); > > return ret; > } > @@ -378,7 +378,7 @@ static void hdlcd_drm_unbind(struct device *dev) > pm_runtime_disable(drm->dev); > of_reserved_mem_device_release(drm->dev); > drm_mode_config_cleanup(drm); > - drm_dev_unref(drm); > + drm_dev_put(drm); > drm->dev_private = NULL; > dev_set_drvdata(dev, NULL); > } > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > index 7ae94a1..1b92f41 100644 > --- a/drivers/gpu/drm/arm/malidp_drv.c > +++ b/drivers/gpu/drm/arm/malidp_drv.c > @@ -665,7 +665,7 @@ static int malidp_bind(struct device *dev) > malidp_runtime_pm_suspend(dev); > drm->dev_private = NULL; > dev_set_drvdata(dev, NULL); > - drm_dev_unref(drm); > + drm_dev_put(drm); > alloc_fail: > of_reserved_mem_device_release(dev); > > @@ -698,7 +698,7 @@ static void malidp_unbind(struct device *dev) > malidp_runtime_pm_suspend(dev); > drm->dev_private = NULL; > dev_set_drvdata(dev, NULL); > - drm_dev_unref(drm); > + drm_dev_put(drm); > of_reserved_mem_device_release(dev); > } > > -- > 2.7.4 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯