Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbdI2T0M (ORCPT ); Fri, 29 Sep 2017 15:26:12 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:33524 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752316AbdI2T0L (ORCPT ); Fri, 29 Sep 2017 15:26:11 -0400 X-Google-Smtp-Source: AOwi7QClZwD9CSRY74Z/GWqDTWd8gDkZ+sT/n/mJwmje5EuUqXFP1Z4PK5+6Ef+r2ESS+szhQ+3WuA== Subject: Re: [PATCH net-next 0/8] net: dsa: change dsa_ptr for a dsa_port To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn References: <20170929183635.8122-1-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: <03cef84e-546d-d8c2-85fb-afc697ced2cb@gmail.com> Date: Fri, 29 Sep 2017 12:26:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170929183635.8122-1-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2069 Lines: 50 On 09/29/2017 11:36 AM, Vivien Didelot wrote: > With DSA, a master net_device is physically wired to a dedicated CPU > switch port. For interaction with the DSA layer, the struct net_device > contains a dsa_ptr, which currently points to a dsa_switch_tree object. > > This is only valid for a switch fabric with a single CPU port. In order > to support switch fabrics with multiple CPU ports, we first need to > change the type of dsa_ptr to what it really is: a dsa_port object. > > This is what this patchset does. The first 4 patches cleans up portions > of DSA core to make the next patches more readable. These next patches > prepare the xmit and receive hot paths and finally change dsa_ptr. This looks nice and clean, as mentioned in patch 5, there may be room for organizing the structure a bit more efficiently such that everything still fits within the first cacheline . > > Vivien Didelot (8): > net: dsa: directly fetch switch in mtk_tag_rcv > net: dsa: directly fetch switch in lan9303_rcv > net: dsa: use cpu_dp in master code > net: dsa: use temporary dsa_device_ops variable > net: dsa: add tagging ops to port > net: dsa: prepare master receive hot path > net: dsa: change dsa_ptr for a dsa_port > net: dsa: remove tag ops from the switch tree > > include/linux/netdevice.h | 4 ++-- > include/net/dsa.h | 19 ++++++++----------- > net/dsa/dsa.c | 6 +++--- > net/dsa/dsa2.c | 15 ++++++++++----- > net/dsa/dsa_priv.h | 7 +------ > net/dsa/legacy.c | 15 ++++++++++----- > net/dsa/master.c | 47 ++++++++++++++++++++++------------------------- > net/dsa/slave.c | 3 +-- > net/dsa/tag_brcm.c | 3 +-- > net/dsa/tag_dsa.c | 3 ++- > net/dsa/tag_edsa.c | 3 ++- > net/dsa/tag_ksz.c | 3 +-- > net/dsa/tag_lan9303.c | 6 ++---- > net/dsa/tag_mtk.c | 12 ++---------- > net/dsa/tag_qca.c | 3 +-- > net/dsa/tag_trailer.c | 3 +-- > 16 files changed, 69 insertions(+), 83 deletions(-) > -- Florian