Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752662AbdI2VSN (ORCPT ); Fri, 29 Sep 2017 17:18:13 -0400 Received: from 9.mo6.mail-out.ovh.net ([87.98.171.146]:32882 "EHLO 9.mo6.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752564AbdI2VRb (ORCPT ); Fri, 29 Sep 2017 17:17:31 -0400 X-Greylist: delayed 2261 seconds by postgrey-1.27 at vger.kernel.org; Fri, 29 Sep 2017 17:17:30 EDT From: Andi Shyti To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti , Nick Dyer Subject: [PATCH 04/12] Input: atmel_mxt_ts - use managed devm_device_add_group Date: Sat, 30 Sep 2017 05:38:31 +0900 Message-Id: <20170929203839.7010-5-andi@etezian.org> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20170929203839.7010-1-andi@etezian.org> References: <20170929203839.7010-1-andi@etezian.org> X-Ovh-Tracer-Id: 12651737255787348634 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeelledrjeekgdduhedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1255 Lines: 35 Commit 57b8ff070f98 ("driver core: add devm_device_add_group() and friends") has added the the managed version for creating sysfs group files. Use devm_device_add_group instead of sysfs_create_group. CC: Nick Dyer Signed-off-by: Andi Shyti --- drivers/input/touchscreen/atmel_mxt_ts.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 7659bc48f1db..e5968f136f08 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -3170,7 +3170,7 @@ static int mxt_probe(struct i2c_client *client, const struct i2c_device_id *id) if (error) return error; - error = sysfs_create_group(&client->dev.kobj, &mxt_attr_group); + error = devm_device_add_group(&client->dev, &mxt_attr_group); if (error) { dev_err(&client->dev, "Failure %d creating sysfs group\n", error); @@ -3190,7 +3190,6 @@ static int mxt_remove(struct i2c_client *client) struct mxt_data *data = i2c_get_clientdata(client); disable_irq(data->irq); - sysfs_remove_group(&client->dev.kobj, &mxt_attr_group); mxt_free_input_device(data); mxt_free_object_table(data); -- 2.14.2