Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752609AbdI2XAn (ORCPT ); Fri, 29 Sep 2017 19:00:43 -0400 Received: from mga03.intel.com ([134.134.136.65]:48515 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752448AbdI2XAm (ORCPT ); Fri, 29 Sep 2017 19:00:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,454,1500966000"; d="scan'208";a="1177155287" Date: Fri, 29 Sep 2017 17:00:07 -0600 From: Keith Busch To: Martin Wilck Cc: Jens Axboe , Christoph Hellwig , Johannes Thumshirn , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Hannes Reinecke , linux-nvme@lists.infradead.org, Martin Wilck Subject: Re: [PATCH 2/2] nvme: use device_add_disk_with_groups() Message-ID: <20170929230006.GQ8463@localhost.localdomain> References: <20170928193637.24707-1-mwilck@suse.com> <20170928193637.24707-2-mwilck@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170928193637.24707-2-mwilck@suse.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 358 Lines: 10 On Thu, Sep 28, 2017 at 09:36:37PM +0200, Martin Wilck wrote: > By using device_add_disk_with_groups(), we can avoid the race > condition with udev rule processing, because no udev event will > be triggered before all attributes are available. > > Signed-off-by: Martin Wilck Looks good. Reviewed-by: Keith Busch