Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752617AbdI2XjU (ORCPT ); Fri, 29 Sep 2017 19:39:20 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:38635 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752505AbdI2XjS (ORCPT ); Fri, 29 Sep 2017 19:39:18 -0400 X-Google-Smtp-Source: AOwi7QC/N/uYcag+Ur7lOwJYS8CKhY8NjxPi9/wZhp1cj7G4bVhvlRLS9EUs5U85fSbSLyj1SIw/IQ== Date: Fri, 29 Sep 2017 16:39:15 -0700 From: Dmitry Torokhov To: Andi Shyti Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH 09/12] Input: raydium_i2c_ts - use managed devm_device_add_group Message-ID: <20170929233915.GE14362@dtor-ws> References: <20170929203839.7010-1-andi@etezian.org> <20170929203839.7010-10-andi@etezian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170929203839.7010-10-andi@etezian.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1962 Lines: 66 On Sat, Sep 30, 2017 at 05:38:36AM +0900, Andi Shyti wrote: > Commit 57b8ff070f98 ("driver core: add devm_device_add_group() > and friends") has added the the managed version for creating > sysfs group files. > > Use devm_device_add_group instead of sysfs_create_group and > remove the action that cleans the sysfs file when exiting the > driver. > > Signed-off-by: Andi Shyti Applied, thank you. > --- > drivers/input/touchscreen/raydium_i2c_ts.c | 18 +----------------- > 1 file changed, 1 insertion(+), 17 deletions(-) > > diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c > index 4f1d3fd5d412..100538d64fff 100644 > --- a/drivers/input/touchscreen/raydium_i2c_ts.c > +++ b/drivers/input/touchscreen/raydium_i2c_ts.c > @@ -943,13 +943,6 @@ static const struct attribute_group raydium_i2c_attribute_group = { > .attrs = raydium_i2c_attributes, > }; > > -static void raydium_i2c_remove_sysfs_group(void *_data) > -{ > - struct raydium_data *ts = _data; > - > - sysfs_remove_group(&ts->client->dev.kobj, &raydium_i2c_attribute_group); > -} > - > static int raydium_i2c_power_on(struct raydium_data *ts) > { > int error; > @@ -1120,7 +1113,7 @@ static int raydium_i2c_probe(struct i2c_client *client, > return error; > } > > - error = sysfs_create_group(&client->dev.kobj, > + error = devm_device_add_group(&client->dev, > &raydium_i2c_attribute_group); > if (error) { > dev_err(&client->dev, "failed to create sysfs attributes: %d\n", > @@ -1128,15 +1121,6 @@ static int raydium_i2c_probe(struct i2c_client *client, > return error; > } > > - error = devm_add_action(&client->dev, > - raydium_i2c_remove_sysfs_group, ts); > - if (error) { > - raydium_i2c_remove_sysfs_group(ts); > - dev_err(&client->dev, > - "Failed to add sysfs cleanup action: %d\n", error); > - return error; > - } > - > return 0; > } > > -- > 2.14.2 > -- Dmitry