Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbdI2XlV (ORCPT ); Fri, 29 Sep 2017 19:41:21 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:38147 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752320AbdI2XlT (ORCPT ); Fri, 29 Sep 2017 19:41:19 -0400 X-Google-Smtp-Source: AOwi7QDgdGwhf8Nl765Ejut0cIpcmnNJ9/dTuHsYmomiukPA7Uzqe99dUIDX3gMeXXCr0bP2n5VD+Q== Date: Fri, 29 Sep 2017 16:41:16 -0700 From: Dmitry Torokhov To: Andi Shyti Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH 12/12] Input: wdt87xx_i2c - use managed devm_device_add_group Message-ID: <20170929234116.GG14362@dtor-ws> References: <20170929203839.7010-1-andi@etezian.org> <20170929203839.7010-13-andi@etezian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170929203839.7010-13-andi@etezian.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1352 Lines: 44 On Sat, Sep 30, 2017 at 05:38:39AM +0900, Andi Shyti wrote: > Commit 57b8ff070f98 ("driver core: add devm_device_add_group() > and friends") has added the the managed version for creating > sysfs group files. > > Use devm_device_add_group instead of sysfs_create_group and > remove the relative sysfs_remove_group. > > Signed-off-by: Andi Shyti Applied, thank you. > --- > drivers/input/touchscreen/wdt87xx_i2c.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/wdt87xx_i2c.c b/drivers/input/touchscreen/wdt87xx_i2c.c > index a9132603ab34..b866cc88d942 100644 > --- a/drivers/input/touchscreen/wdt87xx_i2c.c > +++ b/drivers/input/touchscreen/wdt87xx_i2c.c > @@ -1106,7 +1106,7 @@ static int wdt87xx_ts_probe(struct i2c_client *client, > return error; > } > > - error = sysfs_create_group(&client->dev.kobj, &wdt87xx_attr_group); > + error = devm_device_add_group(&client->dev, &wdt87xx_attr_group); > if (error) { > dev_err(&client->dev, "create sysfs failed: %d\n", error); > return error; > @@ -1117,8 +1117,6 @@ static int wdt87xx_ts_probe(struct i2c_client *client, > > static int wdt87xx_ts_remove(struct i2c_client *client) > { > - sysfs_remove_group(&client->dev.kobj, &wdt87xx_attr_group); > - > return 0; > } > > -- > 2.14.2 > -- Dmitry