Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752636AbdI2XqG (ORCPT ); Fri, 29 Sep 2017 19:46:06 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36919 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752320AbdI2XqF (ORCPT ); Fri, 29 Sep 2017 19:46:05 -0400 X-Google-Smtp-Source: AOwi7QBUCWHW2/epPh2ZCQhjPajx+Cb/2Lyn8icymZAtNP203p8+YkVou98fNTKEPY6BHkHjId0CxQ== Date: Fri, 29 Sep 2017 16:46:01 -0700 From: Dmitry Torokhov To: Andi Shyti Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Nick Dyer Subject: Re: [PATCH 04/12] Input: atmel_mxt_ts - use managed devm_device_add_group Message-ID: <20170929234601.GK14362@dtor-ws> References: <20170929203839.7010-1-andi@etezian.org> <20170929203839.7010-5-andi@etezian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170929203839.7010-5-andi@etezian.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1418 Lines: 43 On Sat, Sep 30, 2017 at 05:38:31AM +0900, Andi Shyti wrote: > Commit 57b8ff070f98 ("driver core: add devm_device_add_group() > and friends") has added the the managed version for creating > sysfs group files. > > Use devm_device_add_group instead of sysfs_create_group. > > CC: Nick Dyer > Signed-off-by: Andi Shyti > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c > index 7659bc48f1db..e5968f136f08 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -3170,7 +3170,7 @@ static int mxt_probe(struct i2c_client *client, const struct i2c_device_id *id) > if (error) > return error; > > - error = sysfs_create_group(&client->dev.kobj, &mxt_attr_group); > + error = devm_device_add_group(&client->dev, &mxt_attr_group); > if (error) { > dev_err(&client->dev, "Failure %d creating sysfs group\n", > error); > @@ -3190,7 +3190,6 @@ static int mxt_remove(struct i2c_client *client) > struct mxt_data *data = i2c_get_clientdata(client); > > disable_irq(data->irq); > - sysfs_remove_group(&client->dev.kobj, &mxt_attr_group); Wrong ordering. > mxt_free_input_device(data); > mxt_free_object_table(data); > > -- > 2.14.2 > -- Dmitry