Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752747AbdI3Aqp (ORCPT ); Fri, 29 Sep 2017 20:46:45 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:46415 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752591AbdI3Aqn (ORCPT ); Fri, 29 Sep 2017 20:46:43 -0400 X-Google-Smtp-Source: AOwi7QAezK28Ox1jjgu3NTSF+SvjS6NJdOU84d/PegnmOyR6VzTplRLXhFeTV0UdibUZqy0fEuyRQfNhLCzE3zTOeEE= MIME-Version: 1.0 In-Reply-To: <20170929171704.azziyvlikbv5qnbd@linux.intel.com> References: <1506434337-15284-1-git-send-email-rubenroy2005@gmail.com> <20170929171704.azziyvlikbv5qnbd@linux.intel.com> From: Nick Desaulniers Date: Fri, 29 Sep 2017 17:46:41 -0700 Message-ID: Subject: Re: [PATCH] tpm: fix duplicate inline declaration specifier To: Jarkko Sakkinen Cc: Ruben Roy , Peter Huewe , Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, trivial@kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 36 Thanks! This fixes a warning I was seeing with Clang: drivers/char/tpm/tpm.h:560:15: warning: duplicate 'inline' declaration specifier [-Wduplicate-decl-specifier] On Fri, Sep 29, 2017 at 10:17 AM, Jarkko Sakkinen wrote: > On Tue, Sep 26, 2017 at 01:58:57PM +0000, Ruben Roy wrote: >> This commit fixes the duplicate inline declaration specifier in >> tpm2_rc_value which caused a warning >> >> Signed-off-by: Ruben Roy >> --- >> drivers/char/tpm/tpm.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h >> index 04fbff2..f4d0272 100644 >> --- a/drivers/char/tpm/tpm.h >> +++ b/drivers/char/tpm/tpm.h >> @@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip) >> } >> #endif >> >> -static inline inline u32 tpm2_rc_value(u32 rc) >> +static inline u32 tpm2_rc_value(u32 rc) >> { >> return (rc & BIT(7)) ? rc & 0xff : rc; >> } >> -- >> 1.8.3.1 >> > > Reviewed-by: Jarkko Sakkinen > > /Jarkko