Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751540AbdI3HBy (ORCPT ); Sat, 30 Sep 2017 03:01:54 -0400 Received: from mail.kapsi.fi ([91.232.154.25]:35441 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdI3HBx (ORCPT ); Sat, 30 Sep 2017 03:01:53 -0400 Subject: Re: [PATCH v3 1/6] gpu: host1x: Enable Tegra186 syncpoint protection To: Dmitry Osipenko , Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170928125044.32516-1-mperttunen@nvidia.com> <20170928125044.32516-2-mperttunen@nvidia.com> <8391dc88-36a1-0b3c-9ffa-42ce0238dc3f@gmail.com> From: Mikko Perttunen Message-ID: <7f1764a7-c41c-3c56-5c7f-5506e6a9fc01@kapsi.fi> Date: Sat, 30 Sep 2017 10:01:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <8391dc88-36a1-0b3c-9ffa-42ce0238dc3f@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 84.249.131.249 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 24 On 09/30/2017 05:41 AM, Dmitry Osipenko wrote: > On 28.09.2017 15:50, Mikko Perttunen wrote: >> .. >> diff --git a/drivers/gpu/host1x/hw/channel_hw.c b/drivers/gpu/host1x/hw/channel_hw.c >> index 8447a56c41ca..b929d7f1e291 100644 >> --- a/drivers/gpu/host1x/hw/channel_hw.c >> +++ b/drivers/gpu/host1x/hw/channel_hw.c >> @@ -147,6 +147,9 @@ static int channel_submit(struct host1x_job *job) >> >> syncval = host1x_syncpt_incr_max(sp, user_syncpt_incrs); >> >> + /* assign syncpoint to channel */ >> + host1x_hw_syncpt_assign_to_channel(host, sp, ch); >> + > > Since you've preserved the comment, what about to extend it with a brief > explanation of what actually the 'assignment' does? Like that CDMA will stop > execution on touching any syncpoint other then the assigned one. Whoops, I actually forgot to remove that :) I think the best would be to remove the comment here and have a more proper description of the feature somewhere else. Mikko