Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751525AbdI3HK1 (ORCPT ); Sat, 30 Sep 2017 03:10:27 -0400 Received: from ud10.udmedia.de ([194.117.254.50]:56960 "EHLO mail.ud10.udmedia.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750984AbdI3HKZ (ORCPT ); Sat, 30 Sep 2017 03:10:25 -0400 Date: Sat, 30 Sep 2017 09:10:22 +0200 From: Markus Trippelsdorf To: Lukas Czerner Cc: "Theodore Ts'o" , Andreas Dilger , linux-ext4@vger.kernel.org, Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, David Howells Subject: Re: [PATCH v2] VFS: Handle lazytime in do_mount() Message-ID: <20170930071022.GA238@x4> References: <20170918192644.GA232@x4> <20170919083506.GA233@x4> <20170919101819.GA233@x4> <20170919103724.GA239@x4> <20170919152500.ce62nirm7gu3lqvq@rh_laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170919152500.ce62nirm7gu3lqvq@rh_laptop> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 36 On 2017.09.19 at 17:25 +0200, Lukas Czerner wrote: > On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote: > > Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from > > internal superblock flags") the lazytime mount option didn't get passed > > on anymore. > > > > Fix the issue by handling the option in do_mount(). > > > > Signed-off-by: Markus Trippelsdorf > > --- > > fs/namespace.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/fs/namespace.c b/fs/namespace.c > > index 54059b142d6b..b633838b8f02 100644 > > --- a/fs/namespace.c > > +++ b/fs/namespace.c > > @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name, > > SB_MANDLOCK | > > SB_DIRSYNC | > > SB_SILENT | > > - SB_POSIXACL); > > + SB_POSIXACL | > > + SB_LAZYTIME); > > Looks good. Although I still think that this can be per mountpoint options. > > Regardless of that, you can add > Reviewed-by: Lukas Czerner Ping? Al could you please take look? Thanks. -- Markus