Date: Sat, 30 Sep 2017 05:48:15 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH] mm: kill kmemcheck again
Message-ID: <20170930054815.0e2c182f@vmware.local.home>
In-Reply-To: <20170927150207.swmcarc4lqlklohr@dhcp22.suse.cz>
References: <20170927112723.16862-1-alexander.levin@verizon.com>
        <20170927150207.swmcarc4lqlklohr@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 986
Lines: 27

On Wed, 27 Sep 2017 17:02:07 +0200
Michal Hocko <mhocko@kernel.org> wrote:

> > Now that 2 years have passed, and all distros provide gcc that supports
> > KASAN, kill kmemcheck again for the very same reasons.  
> 
> This is just too large to review manually. How have you generated the
> patch?

I agree. This needs to be taken out piece by piece, not in one go,
where there could be unexpected fallout.

> 
> My compile test batery failed for i386 allyesconfig for some reason
> which is not entirely clear to me (see attached).  I have applied on top
> of dc972a67cc54585bd83ad811c4e9b6ab3dcd427e and that one compiles fine.
> 
> > Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > Cc: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Sasha Levin <alexander.levin@verizon.com>  
> 
> Anyway I fully support this removal. It is a lot of rarely used code and
> KASAN is much more usable.

Now that my default compilers support KASAN, I'm fine with this removal.

-- Steve