Date: Sat, 30 Sep 2017 21:06:57 +1000
From: "Tobin C. Harding" <me@tobin.cc>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.
Message-ID: <20170930110657.GA25277@eros>
References: <1506758434-3193-1-git-send-email-shreeya.patel23498@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1506758434-3193-1-git-send-email-shreeya.patel23498@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 821
Lines: 20

Hi Shreeya,

We don't usually add a period to the subject line for kernel patches. (reason: we only have about
52 characters for the commit brief description so best not to waste any).

On Sat, Sep 30, 2017 at 01:30:34PM +0530, Shreeya Patel wrote:
> This patch removes unnecessary comments which are there
> to explain why call to memset is in comments. Both of the
> comments are not needed as they are not very useful.

You may like to read Documentation/process/submitting-patches.rst (specifically
section 2) for tips on writing your git log.

        Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
        instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
        to do frotz", as if you are giving orders to the codebase to change
        its behaviour.

Good luck,
Tobin.