Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752792AbdI3LLy (ORCPT ); Sat, 30 Sep 2017 07:11:54 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36171 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751439AbdI3LLx (ORCPT ); Sat, 30 Sep 2017 07:11:53 -0400 X-ME-Sender: X-Sasl-enc: ZJxeXL2kMlMRBz3Je9S8YC+PDW+nayVnGpnslB8QYw+D 1506769912 Date: Sat, 30 Sep 2017 21:11:49 +1000 From: "Tobin C. Harding" To: Srishti Sharma Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] Replace container_of with list_entry Message-ID: <20170930111149.GB25277@eros> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 19 On Sat, Sep 30, 2017 at 12:49:00PM +0530, Srishti Sharma wrote: > Replaces instances of container_of with list_entry to > access current list element. > > Srishti Sharma (6): > Staging: rtl8188eu: core: Use list_entry instead of container_of > Staging: rtl8188eu: core: Use list_entry instead of container_of > Staging: rtl8188eu: core: Use list_entry instead of container_of > Staging: rtl8188eu: core: Use list_entry instead of container_of > Staging: rtl8188eu: core: Use list_entry instead of container_of > Staging: rtl8188eu: core: Use list_entry instead of container_of You may have trouble getting patches merged with duplicate commit logs like this. The reason is that the git index should be grep'able. You may like to squash all of these commits into a single patch since they all do the same thing. The mantra is 'one thing per patch' so this makes sense in this case. Hope this helps, Tobin.