Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751404AbdI3PHy (ORCPT ); Sat, 30 Sep 2017 11:07:54 -0400 Received: from gloria.sntech.de ([95.129.55.99]:48900 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028AbdI3PHx (ORCPT ); Sat, 30 Sep 2017 11:07:53 -0400 From: Heiko Stuebner To: David Wu Cc: linus.walleij@linaro.org, huangtao@rock-chips.com, andy.yan@rock-chips.com, linux-rockchip@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] pinctrl: rockchip: Fix the correct routing config for the gmac-m1 pins of rmii and rgmii Date: Sat, 30 Sep 2017 17:07:27 +0200 Message-ID: <1908269.6t3djq65xf@phil> User-Agent: KMail/5.2.3 (Linux/4.11.0-1-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1506773601-27315-3-git-send-email-david.wu@rock-chips.com> References: <1506773601-27315-1-git-send-email-david.wu@rock-chips.com> <1506773601-27315-3-git-send-email-david.wu@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 639 Lines: 15 Hi David, Am Samstag, 30. September 2017, 20:13:21 CEST schrieb David Wu: > If the gmac-m1 optimization(bit10) is selected, the gpio function > of gmac pins is not valid. We may use the rmii mode for gmac interface, > the pins such as rx_d2, rx_d3, which the rgmii mode used, but rmii not > used could be taken as gpio function. So gmac_rxd0m1 selects the bit2, > and gmac_rxd0m3 select bit10 is more correct. > > Signed-off-by: David Wu the patch subject should mention the the rk3328 whose routing gets fixed (like adding a simple "on rk3328" to it), otherwise Reviewed-by: Heiko Stuebner