Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752178AbdI3POz convert rfc822-to-8bit (ORCPT ); Sat, 30 Sep 2017 11:14:55 -0400 Received: from mail001.aei.ca ([206.123.6.130]:58050 "EHLO mail001.aei.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbdI3POx (ORCPT ); Sat, 30 Sep 2017 11:14:53 -0400 From: Ed Tomlinson To: Greg KH Cc: Ed Tomlinson , "Greg KH , Zhang, Jerry" , , Andrew Morton , , , , Jiri Slaby Subject: Re: Linux 4.13.4 Date: Sat, 30 Sep 2017 11:14:42 -0400 MIME-Version: 1.0 Message-ID: In-Reply-To: <20170930142417.GA10658@kroah.com> References: <20170928083302.GA11022@kroah.com> <79eb01dc-9f92-42fd-85c1-e4dcb2d5de4c@aei.ca> <20170930142417.GA10658@kroah.com> User-Agent: Trojita/v0.7-254-g58690b61; Qt/5.9.1; xcb; Linux; Arch Linux Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1925 Lines: 66 Hi I did things old school via patch -R. This is what I reverted: --- diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index 4083be61b328..6417febe18b9 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c @@ -95,9 +95,8 @@ int psp_wait_for(struct psp_context *psp, uint32_t reg_index, int i; struct amdgpu_device *adev = psp->adev; - val = RREG32(reg_index); - for (i = 0; i < adev->usec_timeout; i++) { + val = RREG32(reg_index); if (check_changed) { if (val != reg_val) return 0; diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c index c98d77d0c8f8..6f80ad8f588b 100644 --- a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c +++ b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c @@ -237,11 +237,9 @@ int psp_v3_1_bootloader_load_sos(struct psp_context *psp) /* there might be handshake issue with hardware which needs delay */ mdelay(20); -#if 0 ret = psp_wait_for(psp, SOC15_REG_OFFSET(MP0, 0, mmMP0_SMN_C2PMSG_81), RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_81), 0, true); -#endif return ret; } --- Thanks Ed On Saturday, September 30, 2017 10:24:17 AM EDT, Greg KH wrote: > On Sat, Sep 30, 2017 at 09:49:28AM -0400, Ed Tomlinson wrote: >> Hi, >> >> This build causes very annoying flickering on my display. I >> am using the in >> kernel amdgpu module to drive a RX480 with 4G via display port. When X is >> started (kde) I get flickers that are extrememly distracting. The linux >> install is arch stable and is up to date. Nothing interesting >> in dmesg. ... > > What was the git commit id that you reverted to fix the issue? > Is the issue in 4.14-rc2? > > thanks, > > greg k-h > >