Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751757AbdI3R7U (ORCPT ); Sat, 30 Sep 2017 13:59:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:59200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751141AbdI3R7S (ORCPT ); Sat, 30 Sep 2017 13:59:18 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12F302188D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sat, 30 Sep 2017 18:59:13 +0100 From: Jonathan Cameron To: Martin Kepplinger Cc: Harinath Nampally , knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, amsfield22@gmail.com Subject: Re: [PATCH v3 1/3] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names. Message-ID: <20170930185913.4a2c85e3@archlinux> In-Reply-To: <768af6828fe70f4a0bd7ef402073d9f3@posteo.de> References: <1506336008-4480-1-git-send-email-harinath922@gmail.com> <1506336008-4480-2-git-send-email-harinath922@gmail.com> <768af6828fe70f4a0bd7ef402073d9f3@posteo.de> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 472 Lines: 17 On Wed, 27 Sep 2017 08:52:54 +0200 Martin Kepplinger wrote: > Am 25.09.2017 12:40 schrieb Harinath Nampally: > > Improves code readability, no impact on functionality. > > > > Signed-off-by: Harinath Nampally > > --- > > I'd prefer a shorter subject line here too, see patch 2/3 Agreed. I'm unconvinced the change helps. Perhaps that is because I don't fully understand why you are making the change? Thanks, Jonathan