Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751731AbdI3USX (ORCPT ); Sat, 30 Sep 2017 16:18:23 -0400 Received: from mga01.intel.com ([192.55.52.88]:61982 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbdI3USW (ORCPT ); Sat, 30 Sep 2017 16:18:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,459,1500966000"; d="scan'208";a="1200811597" From: Thiago Macieira To: Petar Penkov CC: , Al Viro , "Eric Dumazet" Subject: Re: [v1] iov_iter: fix page_copy_sane for compound pages Date: Sat, 30 Sep 2017 12:24:42 -0700 Message-ID: <502375193.icN6k8xHrH@tjmaciei-mobl1> Organization: Intel Corporation In-Reply-To: <20170829182032.61961-1-ppenkov@google.com> References: <20170829182032.61961-1-ppenkov@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Originating-IP: [10.252.129.244] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 21 On Tuesday, 29 August 2017 11:20:32 PDT Petar Penkov wrote: > Issue is that if the data crosses a page boundary inside a compound > page, this check will incorrectly trigger a WARN_ON. > > To fix this, compute the order using the head of the compound page and > adjust the offset to be relative to that head. > > Fixes: 72e809ed81ed ("iov_iter: sanity checks for copy to/from page > primitives") Hello Is this patch slated to end up in one of the 4.13.x updates? It landed on v4.14-rc2 already but seems to have missed the 4.13.3 and 4.13.4 tagging. Without this patch, I can't connect any USB Ethernet or the kernel will start producing that WARN_ON message and returning -EFAULT for quite a few programs. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center