Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbdI3XWk (ORCPT ); Sat, 30 Sep 2017 19:22:40 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:48923 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbdI3XWi (ORCPT ); Sat, 30 Sep 2017 19:22:38 -0400 X-Google-Smtp-Source: AOwi7QAsKYQ3uta3KFMbI3Kl+ezWiYgoL0j5POwfhZCDvRu81jJdXwCNXsAj63Mc785Wg+m+Iv01TQ== Date: Sat, 30 Sep 2017 16:22:34 -0700 From: Nick Desaulniers To: Paolo Bonzini Cc: Josh Triplett , kay@vrfy.org, avi@redhat.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] KVM: VMX: check match table Message-ID: <20170930232234.ue665ojgjkegjpag@lostoracle.net> References: <20170926042540.10100-1-nick.desaulniers@gmail.com> <20170926171219.ulnknakiohm2whpd@x> <498ed7dc-41b2-a075-cdce-e63a80842d39@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <498ed7dc-41b2-a075-cdce-e63a80842d39@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 453 Lines: 12 On Wed, Sep 27, 2017 at 02:36:03PM +0200, Paolo Bonzini wrote: > On 26/09/2017 19:12, Josh Triplett wrote: > > Does this make any other checks redundant and removable? > > It would make sense to place it in cpu_has_kvm_support instead cpu_has_kvm_support() or cpu_has_vmx()? >, and the same in svm.c's has_svm. I don't follow (but I also don't know what any of these three letter acryonyms acronyms stand for), does svm depend on vmx or vice-versa?