Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752462AbdLAGUk (ORCPT ); Fri, 1 Dec 2017 01:20:40 -0500 Received: from a.mx.secunet.com ([62.96.220.36]:41726 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbdLAGUj (ORCPT ); Fri, 1 Dec 2017 01:20:39 -0500 Date: Fri, 1 Dec 2017 07:20:36 +0100 From: Steffen Klassert To: CC: "David S. Miller" , Herbert Xu , , , , , Subject: Re: [PATCH net-next 1/3] xfrm: Fix xfrm_replay_overflow_offload_esn Message-ID: <20171201062036.qpnpezp2rnior7lu@gauss3.secunet.de> References: <1511862571-3494-1-git-send-email-yossefe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1511862571-3494-1-git-send-email-yossefe@mellanox.com> User-Agent: NeoMutt/20170609 (1.8.3) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: F51C18D6-2E7C-4999-AE73-1821AB5BB0F1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 538 Lines: 13 On Tue, Nov 28, 2017 at 11:49:28AM +0200, yossefe@mellanox.com wrote: > From: Yossef Efraim > > In case of wrap around, replay_esn->oseq_hi is not updated > before it is tested for it's actual value, leading function > to fail with overflow indication and packets being dropped. > > This patch updates replay_esn->oseq_hi in the right place. > > Fixes: d7dbefc45cf5 ("xfrm: Add xfrm_replay_overflow functions for offloading") > Signed-off-by: Yossef Efraim Applied to ipsec-next, thanks!