Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbdLAI5s (ORCPT ); Fri, 1 Dec 2017 03:57:48 -0500 Received: from smtp3-g21.free.fr ([212.27.42.3]:33882 "EHLO smtp3-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbdLAI5q (ORCPT ); Fri, 1 Dec 2017 03:57:46 -0500 Subject: Re: [PATCH 2/2] mtd: m25p80: restore the addressing mode when stop using the flash To: Zhiqiang Hou , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, richard@nod.at References: <20171124100848.1828-1-Zhiqiang.Hou@nxp.com> <20171124100848.1828-3-Zhiqiang.Hou@nxp.com> From: Cyrille Pitchen Message-ID: Date: Fri, 1 Dec 2017 09:57:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171124100848.1828-3-Zhiqiang.Hou@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1479 Lines: 53 Hi Hou, Le 24/11/2017 à 11:08, Zhiqiang Hou a écrit : > From: Hou Zhiqiang > > Add .shutdown function to restore the addressing mode in reboot > process, and add the same operation to the .remove function. > > Signed-off-by: Hou Zhiqiang > --- > drivers/mtd/devices/m25p80.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c > index dbe6a1de2bb8..867bd2d5a267 100644 > --- a/drivers/mtd/devices/m25p80.c > +++ b/drivers/mtd/devices/m25p80.c > @@ -307,10 +307,17 @@ static int m25p_remove(struct spi_device *spi) > { > struct m25p *flash = spi_get_drvdata(spi); > > + spi_nor_restore_addr_mode(&flash->spi_nor); maybe add a new line here. Otherwise, this looks good :) Best regards, Cyrille > /* Clean up MTD stuff. */ > return mtd_device_unregister(&flash->spi_nor.mtd); > } > > +static void m25p_shutdown(struct spi_device *spi) > +{ > + struct m25p *flash = spi_get_drvdata(spi); > + > + spi_nor_restore_addr_mode(&flash->spi_nor); > +} > /* > * Do NOT add to this array without reading the following: > * > @@ -386,6 +393,7 @@ static struct spi_driver m25p80_driver = { > .id_table = m25p_ids, > .probe = m25p_probe, > .remove = m25p_remove, > + .shutdown = m25p_shutdown, > > /* REVISIT: many of these chips have deep power-down modes, which > * should clearly be entered on suspend() to minimize power use. >