Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752138AbdLAJtV (ORCPT ); Fri, 1 Dec 2017 04:49:21 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.161]:15818 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbdLAJtR (ORCPT ); Fri, 1 Dec 2017 04:49:17 -0500 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw87WiuNN2FDaY X-RZG-CLASS-ID: mo00 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string From: "H. Nikolaus Schaller" In-Reply-To: <6ca5f2ea-e725-9a9e-ac02-e16beca4a1a0@ti.com> Date: Fri, 1 Dec 2017 10:48:38 +0100 Cc: Sebastian Reichel , Tony Lindgren , Thierry Reding , David Airlie , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt_Cousson?= , Russell King , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Julia Lawall , Sean Paul , dri-devel@lists.freedesktop.org, DTML , Linux Kernel Mailing List , linux-omap , Linux ARM , linux-fbdev@vger.kernel.org, Discussions about the Letux Kernel , kernel@pyra-handheld.com Content-Transfer-Encoding: 7bit Message-Id: <0324FA0E-F06A-41F1-84AD-5BC72F6B6BFF@goldelico.com> References: <20171128160437.GD28152@atomide.com> <20171128161834.GE28152@atomide.com> <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> <20171130152430.GM28152@atomide.com> <20171130220633.imkfyeiqtftnw4j4@earth> <6ca5f2ea-e725-9a9e-ac02-e16beca4a1a0@ti.com> To: Tomi Valkeinen X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 45 Hi Tomi, > Am 01.12.2017 um 09:13 schrieb Tomi Valkeinen : > > On 01/12/17 00:06, Sebastian Reichel wrote: > >>>>> How about let's call it a "typo fix" then? :) >>>> >>>> Well, it is not really a typo. >>> >>> Well what if the stable people pick it into earlier stable series >>> based on the word fix in the subject? That has happened before. >>> >>> I suggest you update the dts patches to use wording like >>> "update compatible to use new naming" or something similar. >> >> Patch 4/4 is a Fix and should be applied to stable trees. "omapdss," >> prefix was never supposed to be in the DTS files, is not supposed to >> be in there now and will break some time in the future. >> >> Explanation: The early init of omapdss adds the prefix at runtime, >> so that the binding can use generic properties and the kernel can >> use omapdss specific drivers until the generic ones can be used > > This is true, but the extra "omapdss" does not cause any issues at the > moment, and the time when it causes issues is still many kernel versions > in the future. > > But, yes, thinking about this, I agree, it's better to pick this one > separately as a fix (after rebasing it on top of current maineline so > that it doesn't depend on the toppoly name change), and leaving the > toppoly->tpo change as a cleanup. Just a note: there is no toppoly->tpo change for *this* panel and Pandora board. Just omapdss removal. The GTA04 needs a toppoly->tpo change but no omapdss, removal. So they solve different problems and are independent of each other. GTA04: change vendor string Pandora: remove omapdss, prefix BR and thanks, Nikolaus